Empty strings #1619
Merged
Empty strings #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
requested changes
Oct 14, 2021
| return deserialize(rootNode,path, true); | ||
| } | ||
|
|
||
| public SwaggerParseResult deserialize(JsonNode rootNode, String path, boolean allowEmptyStrings) { |
There was a problem hiding this comment.
It makes probably sense to pass directly ParseOptions options to deserializer as other future options could be meaningful
Comment on lines
399
to
401
| if (result.isAllowEmptyStrings() && value != null) { | ||
| tag.setName(value); | ||
| } |
There was a problem hiding this comment.
This applies to all similar code change: with the change if flag is false no value will be set, even when present and not empty!
frantuma
reviewed
Oct 14, 2021
| @@ -396,12 +397,12 @@ public Tag getTag(ObjectNode obj, String location, ParseResult result) { | |||
| Tag tag = new Tag(); | |||
|
|
|||
| String value = getString("name", obj, true, location, result); | |||
| if (result.isAllowEmptyStrings() && value != null) { | |||
| if (result.isAllowEmptyStrings() && value != null || !result.isAllowEmptyStrings() && !StringUtils.isBlank(value)) { | |||
There was a problem hiding this comment.
I would add parenthesis for clarity:
if ((result.isAllowEmptyStrings() && value != null) || (!result.isAllowEmptyStrings() && !StringUtils.isBlank(value))) {
frantuma
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow Empty strings as valid when deserializing a specification.