Merge pull request #1403 from brhaible/issue-1402

Issue 1402: Fix NPE when a path references an undeclared path parameter.
swagger-api · Aug 1, 2020 · 93676f0 · 93676f0
2 parents a92ddf7 + 680c88b
commit 93676f0
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java b/modules/swagger-parser-v3/src/main/java/io/swagger/v3/parser/util/OpenAPIDeserializer.java
@@ -560,12 +560,16 @@ public Paths getPaths(ObjectNode obj, String location, ParseResult result) {
                                 if (!definedInPathLevel) {
                                     List<Operation> operationsInAPath = getAllOperationsInAPath(pathObj);
                                     operationsInAPath.forEach(operation -> {
-                                        operation.getParameters().forEach(parameter -> {
+                                        List<Parameter> operationParameters = operation.getParameters();
+                                        if (operationParameters == null) {
+                                            operationParameters = Collections.<Parameter>emptyList();
+                                        }
+                                        operationParameters.forEach(parameter -> {
                                             if(PATH_PARAMETER.equalsIgnoreCase(parameter.getIn()) && Boolean.FALSE.equals(parameter.getRequired())){
                                                 result.warning(location, "For path parameter "+ parameter.getName() + " the required value should be true");
                                             }
                                         });
-                                        if (!isPathParamDefined(pathParam, operation.getParameters())) {
+                                        if (!isPathParamDefined(pathParam, operationParameters)) {
                                             result.warning(location + ".'" + pathName + "'"," Declared path parameter " + pathParam + " needs to be defined as a path parameter in path or operation level");
                                             return;
                                         }