Fixed unnecessary scopes mutation

[frol]

The issue due to the mutated scopes popped up in Swagger-UI: swagger-api/swagger-ui#2483

I am not sure if this is a correct solution, but it works for me.

/cc @fehguy @janslow

[frol]

This attempt seems to be wrong as the tests explicitly expect that vendorExtensions will be mounted. Thus, I think, the iteration over the list of scopes should be fixed in Swagger UI project.

I keep this PR open until someone from the maintainers makes a final decision.

[janslow]

Overriding vendorExtensions on the scopes object could also cause issues if an API has a scope called vendorExtension. A safer property name for vendor extensions would be to prefix that name with x- (e.g., x-vendorExtensions) or use a symbol as the property name (which probably isn't ok due to compatibility with old JS engines).

Another option, which would solve this bug would be to use Object.defineProperty to make vendorExtensions non-enumerable.

Finally, is there a reason to aggregate all of the vendor extension properties into a single object, as opposed to just adding each of them to the main object?

[frol]

Just for the record, this PR was merged and 5 hours later, it was reverted in d916f52

Also, beware that now it not only adds vendorExtensions, but also removes all scopes which happen to start with x- (IMHO, for no good reason at all).

[fehguy]

The fix will be addressed in a Swagger-UI patch, and believe it or not, for good reason. The patch supplied here didn't make sense. See swagger-api/swagger-ui@30f0848

Pull master and enjoy

[frol]

The patch supplied here didn't make sense.

I agree and I pointed this out in my second comment here. I didn't expect it would be merged (and I also stated that), so I was just surprised that it was merged to be reverted a few hours later. I wrote the last comment just so people don't get confused.

Thank you for the proper fix!