Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config docs #199

Closed
wants to merge 4 commits into from
Closed

Config docs #199

wants to merge 4 commits into from

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Oct 13, 2014

Includes these changes:

  • docs/config.rst - documentation for defaults.js
  • add link to README.md and make docker docs more concise
  • sort dependencies to prevent duplicates and merge conflicts
  • re-order defaults.js so that related configuration options are together

The codegen settings don't do anything with these defaults, so I wasn't able to provide much detail.

@mohsen1
Copy link
Contributor

mohsen1 commented Oct 13, 2014

@dnephin Thanks for this PR. I'm making some modifications to the README while I'm merging this.

Please take a look and let me know if you're okay with this:

https://github.com/wordnik/swagger-editor/blob/dnephin-config_docs/README.md

@dnephin
Copy link
Contributor Author

dnephin commented Oct 14, 2014

@mohsen1

I think your edit is misleading. The config section is under the Docker section, but they are not related.

The config section applies to everything under "Running Locally".

I believe it should be made it's own section under "Running Locally", not Development

@mohsen1
Copy link
Contributor

mohsen1 commented Oct 14, 2014

@dnephin Cool. Fixed those issues and also Node.js version you brought up in the comments in my other commit. Merged to master.

Thanks!

@mohsen1 mohsen1 closed this Oct 14, 2014
@dnephin
Copy link
Contributor Author

dnephin commented Oct 14, 2014

Thanks! looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants