Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fileUpload while contentType: "multipart/form-data" #1141

Merged
merged 9 commits into from
Dec 29, 2016
Merged

Conversation

saharj
Copy link
Contributor

@saharj saharj commented Dec 29, 2016

Fixes #599

Browsers I manually tested this feature in

  • Google Chrome

@saharj saharj merged commit d0df2f6 into master Dec 29, 2016
@NeoElit
Copy link

NeoElit commented Jan 29, 2017

Hi,
I'm not so familiar with npm. I wanted to create a local release from master for this fix. Is that possible? Something like this https://github.com/swagger-api/swagger-editor/releases/download/v2.10.4/swagger-editor.zip
Currently I've cloned master and running npm start which takes a long time to build at first.
Can anyone point me in the right docs or anything i can look into?

Sorry it was in the doc: npm run build

@NeoElit
Copy link

NeoElit commented Jan 30, 2017

Also multipart form submits 'undefined' for empty fields.
These are my request params:

parameters:
        - name: id
          in: path
          description: Id of the Place
          required: true
          type: number
          format: integer
        - name: 'media[media]'
          in: formData
          type: file
          description: 'Attachment media data, if local'
          required: false
        - name: 'media[remote_source_url]'
          in: formData
          type: string
          description: 'Url of the media source, if not a local media'
          required: false

When field for media[remote_source_url] is left empty, it's sending undefined to server as value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants