Add support for XmlSchema annotation during model generation #4278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frantuma your thoughts on this PR? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to enable Model resolver of swagger-core to extract the XML namespace from XmlRootElement if no namespace attribute has been set, but an XmlSchema annotation is present in the java package where the class annotated with XmlRootElement exists
I had to add these changes, as we utilize have a XSD schema file -> JAXB Generator -> OpenAPI Model generation flow.
Changing the annotation directly is unfortunately not an option for us, hence this PR.
Please let me know if there are further questions / requests.