Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref #3911 - gives preferred status to first mapper errors #3940

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

adagios
Copy link
Contributor

@adagios adagios commented Apr 20, 2021

Implements option 2.1 discussed on the Issue: logs errors for all mappers, giving more importance to the preferred one.

I wrote a test to confirm the behaviour, but it produces a lot of error logging and I don't know if it makes sense to include it. I tend to dislike tests that log a lot of stacktraces.

@frantuma frantuma merged commit ef7df86 into swagger-api:master Nov 2, 2022
@frantuma
Copy link
Member

frantuma commented Nov 2, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants