Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP] Symfony generator enhancements #6016

Merged
merged 8 commits into from
Jul 10, 2017

Conversation

ksm2
Copy link
Contributor

@ksm2 ksm2 commented Jul 9, 2017

PR checklist

  • Read the contribution guidelines.
  • Ran the shell/batch script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)
  • Filed the PR against the correct branch: master for non-breaking changes and 2.3.0 branch for breaking (non-backward compatible) changes.

Description of the PR

Hi, after an exciting G20 weekend here in Hamburg, Germany, I finally implemented the following improvements to the Symfony generator for #5985:

  • Use camelize instead of initialCaps
  • Use File.separator instead of "/" to make it work in the Windows platform
  • Better README with installation instructions, how to start, etc
  • Write an options test
  • Fixing codegen errors in the models
  • Parsing header, path, query, and form parameters
  • Generate setters for auth methods to handle them accordingly
  • Change "getters" to "issers" for boolean properties (Symfony standard)

@ksm2 ksm2 changed the title 5985 symfony enhancements Symfony generator enhancements Jul 9, 2017
@wing328 wing328 merged commit d522236 into swagger-api:master Jul 10, 2017
@wing328 wing328 changed the title Symfony generator enhancements [PHP] Symfony generator enhancements Jul 10, 2017
@wing328 wing328 added this to the v2.2.3 milestone Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants