[PHP][Symfony] Add a Symfony server generator #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be783fd to
aaba610
Compare
|
@ksm2 thanks for the contribution! We'll review and let you know if we've any question. |
|
@ksm2 overall it looks pretty good 👍 There are some enhancements I can think of and will create a separate ticket (issue) for tracking. |
|
Tweet https://twitter.com/wing328/status/882522959159541761 to promote the new generator. Please help retweet. |
5 tasks
|
FYI. Opened #5985 to track enhancements. |
|
@ksm2 this looks very nice! \o/ |
dmpliamplias
pushed a commit
to inventage/swagger-codegen
that referenced
this pull request
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates)2.3.0branch for breaking (non-backward compatible) changes.Description of the PR
Hi, I added an implementation for a Symfony server bundle generator (see issue #3486)!