SWG-7517 updating the resolving options of swagger-parser-v3 #12140
+40
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frantuma
reviewed
May 9, 2023
| @@ -674,6 +678,21 @@ private ParseOptions buildParseOptions() { | |||
| options.setFlatten(true); | |||
| options.setFlattenComposedSchemas(flattenInlineSchema); | |||
| options.setSkipMatches(this.skipInlineModelMatches); | |||
|
|
|||
| if (Objects.equals(System.getenv("SAFELY_RESOLVE_URL"), "true")) { | |||
There was a problem hiding this comment.
would apply the same logic, limited to the new options, to https://github.com/swagger-api/swagger-codegen/pull/12140/files#diff-98b18ce4b3c3949e219dcc49c873cae48091f65f5be0e55d299617d03588dbe1L581
There was a problem hiding this comment.
Yes, let's keep consistency using same logic
There was a problem hiding this comment.
Thanks for the reviews! :) Sorry about the delay, I was unavailable last couple of days.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
This PR adds possibility to utilize allow and block lists provided through environmental variables when using OpenAPIV3Parser (swagger-parser-v3) in order to safely resolve definitions.
To see the detailed explanation of this functionality please see the following pull requests:
swagger-api/swagger-parser#1910
swagger-api/swagger-parser#1911