[Java] [okhttp-gson] Updating OkHttp to version 3.x #9606
Comments
|
Thanks for this, a patch/PR is more than welcome! this basically would mean touching related java class In case the differences are massive, it could make sense to add a new library option this would still involve |
4 tasks
|
Any progress about this? |
|
Anything yet? |
|
Any news about this? |
|
Any update on this? |
deepsan
added a commit
to deepsan/swagger-codegen
that referenced
this issue
Jan 12, 2023
Add support for okhttp4-gson as a replacement for okhttp-gson okhttp-gson is based on okhttp 2.x which is no longer supported. okhttp 3.x is also [not supported anymore](https://square.github.io/okhttp/security/security/) Creating a new target for codegen since okhttp 4.x is a breaking change over the okhttp 2.x with the changed package names. The overall change is similar to the existing code with a few updates - updates due to deprecations documented in https://square.github.io/okhttp/changelogs/changelog_3x/#version-300-rc1 - kept the utility methods in the existing code as-is tested `mvn package`, ran the petstore generation scripts and the integration tests that are generated Fixes swagger-api#9606
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I'd like to gauge the appetite for upgrading the version of OkHttp in the
okhttp-gsonmodule to a version in the 3.x series. Version 2.7.5 dates back to Feb 26, 2016, and there hasn't been an update since then.Happy to put together a patch just for this module, but I first wanted to check to see if this is something that makes sense? Would this type of change need to wait for a major release of swagger-codegen, or could it be something that's released in a minor version - from what I can tell there would be API changes given the OkHttp package name is different in version 3.x and the API in okhttp-gson exposes some OkHttp classes.
Swagger-codegen version
3.0.10.
Related issues/PRs
This would help make progress on kubernetes-client/java#430. We'd love to be using a more recent version of OkHttp!
Suggest a fix/enhancement
Would be willing to offer up a patch (I have something already) if there's someone that would be willing to guide me through the process (my first time committing to this repo, so I might be missing some subtleties).
The text was updated successfully, but these errors were encountered: