Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lvm it fix/missing discriminator #790

Merged
merged 2 commits into from
Nov 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -1333,6 +1333,8 @@ public CodegenModel fromModel(String name, Schema schema, Map<String, Schema> al
}
codegenModel.getVendorExtensions().put(CodegenConstants.IS_ALIAS_EXT_NAME, typeAliases.containsKey(name));

codegenModel.discriminator = schema.getDiscriminator();

if (schema.getXml() != null) {
codegenModel.xmlPrefix = schema.getXml().getPrefix();
codegenModel.xmlNamespace = schema.getXml().getNamespace();
Expand Down Expand Up @@ -1398,11 +1400,8 @@ else if (schema instanceof ComposedSchema) {
// interfaces (intermediate models)
if (allOf != null && !allOf.isEmpty()) {

if (schema.getDiscriminator() != null) {
codegenModel.discriminator = schema.getDiscriminator();
if (codegenModel.discriminator != null && codegenModel.discriminator.getPropertyName() != null) {
codegenModel.discriminator.setPropertyName(toVarName(codegenModel.discriminator.getPropertyName()));
}
if (codegenModel.discriminator != null && codegenModel.discriminator.getPropertyName() != null) {
codegenModel.discriminator.setPropertyName(toVarName(codegenModel.discriminator.getPropertyName()));
}

for (int i = 0; i < allOf.size(); i++) {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
package io.swagger.codegen.v3.generators.java;

import io.swagger.codegen.v3.ClientOptInput;
import io.swagger.codegen.v3.DefaultGenerator;
import io.swagger.codegen.v3.config.CodegenConfigurator;
import org.apache.commons.io.FileUtils;
import org.junit.rules.TemporaryFolder;
import org.testng.Assert;
import org.testng.annotations.Test;

import java.io.File;

public class JavaPolymorphicAnnotationCodegenTest {

private TemporaryFolder folder = new TemporaryFolder();

@Test(description = "verify that jackson-polymorphism annotations are generated")
public void testParameterOrders() throws Exception {
this.folder.create();
final File output = this.folder.getRoot();

final CodegenConfigurator configurator = new CodegenConfigurator()
.setLang("spring")
.setInputSpecURL("src/test/resources/3_0_0/polymorphicSchema.yaml")
.setOutputDir(output.getAbsolutePath());

final ClientOptInput clientOptInput = configurator.toClientOptInput();
new DefaultGenerator().opts(clientOptInput).generate();

final File petControllerFile = new File(output, "/src/main/java/io/swagger/model/PolymorphicResponse.java");
final String content = FileUtils.readFileToString(petControllerFile);

Assert.assertTrue(content.contains(
"@JsonTypeInfo(use = JsonTypeInfo.Id.NAME, include = JsonTypeInfo.As.PROPERTY, property = \"type\", visible = true )\n" +
"@JsonSubTypes({\n" +
" @JsonSubTypes.Type(value = Error.class, name = \"Error\"),\n" +
" @JsonSubTypes.Type(value = Success.class, name = \"Success\"),\n" +
"})"));

this.folder.delete();
}
}
63 changes: 63 additions & 0 deletions src/test/resources/3_0_0/polymorphicSchema.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
openapi: 3.0.3
info:
description: This is a simple API
version: "1.0.0"
title: Simple Inventory API
servers:
- description: test definition
url: /
paths:
/provision:
get:
tags:
- provision
summary: inheritanceTest
operationId: provision
description: inheritanceTest
responses:
200:
description: default response
content:
application/json:
schema:
$ref: '#/components/schemas/PolymorphicResponse'

components:
schemas:
PolymorphicResponse:
type: object
required:
- type
properties:
type:
type: string
enum:
- Success
- Error
description: the descriminator
discriminator:
propertyName: type
Success:
allOf:
- $ref: '#/components/schemas/PolymorphicResponse'
- type: object
required:
- target
properties:
target:
type: string
description: some target value
dialogId:
type: string
format: uuid
description: some dialogId
Error:
allOf:
- $ref: '#/components/schemas/PolymorphicResponse'
- type: object
required:
- message
properties:
message:
type: string
description: the message describing the error