-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol mode not outputting css #31
Comments
Hi @iansoper, the Cheers, |
Ah, forgot to mention: For the above mentioned reason, the |
That makes sense, thanks for clarifying. |
But wouldn't you still need the dimensions in CSS? When using
And then some inline CSS with the dimensions of the SVG symbols, e.g.: .svg-svg--logo-dims { width: 139px; height: 65px; } Is it not possible to have this CSS output to a separate file? |
Good point. Let me think about this. Will get back to you later. |
I just pushed a new version out the door that supports creating a dimensions stylesheet along with non-CSS sprites ( |
@jkphl It looks like the mode.stack.dimensions doesn't work with value TRUE (as it is noticed in the documentation, but it should work now, doesn't it?) |
@LostSenSS I can't confirm this. For me, a basic configuration like var config = {
mode: {
stack: {
dimensions: true,
render: {
css: true
}
\
}
} just works fine. Could you please post your full configuration? |
@jkphl My configuration: default: {
options: {
shape: {
id: {
separator: '-'
}
},
mode: {
stack: {
sprite: 'sprite.svg',
render: {
scss: {
dest: '../../../css/blocks/_svg-dim.scss'
}
},
prefix: '.',
dimensions: true
}
}
},
src: 'img/svg/**/*.svg',
dest: 'img/svg-sprite/'
} I tried your configuration but I got the same: .img-svg-bd-dims {
width: 15px;
height: 9px;
}
.img-svg-menu-dims {
width: 25px;
height: 15px;
} But I wanted to get: .img-svg-bd {
width: 15px;
height: 9px;
}
.img-svg-menu {
width: 25px;
height: 15px;
} |
@LostSenSS It seems like you misinterpreted what setting |
@jkphl Thank you very much, it works right. There is only one thing: |
@LostSenSS Sorry, my fault: Please set |
@jkphl Looks like it doesn't work: default: {
options: {
shape: {
id: {
separator: '-'
}
},
mode: {
stack: {
sprite: 'sprite.svg',
render: {
scss: {
dest: '../../../css/blocks/_svg-dim.scss'
}
},
prefix: '.%s',
dimensions: '%s'
}
}
},
src: 'img/svg/**/*.svg',
dest: 'img/svg-sprite/'
} Result: img-svg-bd {
width: 15px;
height: 9px;
}
img-svg-menu {
width: 25px;
height: 15px;
} |
@LostSenSS Sorry, that was a bug which is now fixed with release v1.0.18. |
When using these mode settings the css file(s) for
symbol
mode do not get created. Theview
mode CSS/LESS/SCSS files do get created, however.The text was updated successfully, but these errors were encountered: