Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization for SvgPointCollectionConverter parser #808

Conversation

wieslawsoltes
Copy link
Contributor

Reference Issue

Split from #786

What does this implement/fix? Explain your changes.

Performance optimizations for SvgPointCollectionConverter parser

dotnet run -c Release -f netcoreapp3.1 -- -f '*SvgPointCollectionConverter_*'
  • with CoordinateParser
Method Mean Error StdDev Op/s Rank Gen 0 Gen 1 Gen 2 Allocated
SvgPointCollectionConverter_Parse 495.0 ns 5.43 ns 5.08 ns 2,020,232.5 1 0.0067 - - 136 B
  • with StringSplitEnumerator
Method Mean Error StdDev Op/s Rank Gen 0 Gen 1 Gen 2 Allocated
SvgPointCollectionConverter_Parse 460.4 ns 3.17 ns 2.81 ns 2,171,837.9 1 0.0072 - - 136 B

Any other comments?

@inforithmics
Copy link
Contributor

inforithmics commented Mar 15, 2022

I think this can now be merged because. The Roslyn Compiler can soon do switches on ReadonlySpans
see issue.
dotnet/csharplang#1881

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants