feat(config-utl): makes possibly old format known violations forward compatible #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compatible with the new one
|
Code Climate has analyzed commit d8d8782 and detected 0 issues on this pull request. View more on Code Climate. |
9 tasks
sverweij
added a commit
that referenced
this pull request
Dec 18, 2023
## Description - adds a cache format version attribute - adds a check to skip using the cache when the version found in the cache is too low - makes the typescript typings in some of the cache related modules a bit more readable (and valid). ## Motivation and Context There are some changes in the dependency-cruiser output format that are incompatible between version 15 and 16. For use without a cache (or _known violations_, but see #890 for that) this presents no issues. The cache can still contain the old format, though, which might result in slightly unexpected output or disturbing looking errors. With this feature dependency-cruiser will ignore the contents of the cache when the format version of that cache is too low. ## How Has This Been Tested? - [x] green ci - [x] additional non-regression tests ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] Documentation only change - [ ] Refactor (non-breaking change which fixes an issue without changing functionality) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Merged
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description, Motivation and Context
... to prevent users from bumping into inexplicable errors. See the comment in
extract-known-violations.mjs for details.
How Has This Been Tested?
Types of changes
Checklist
📖
⚖️