fix: replace relative-require with our own resolveDependencyData #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…void errors when package.json isn't exported
|
updated to latest vite too as for some reason pnpm i left it in an inconsistent state for me (maybe because of the override that wasn't updated by renovate?) |
|
note to future self: cache results for resolved svelte fields |
bluwy
approved these changes
Jan 20, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid errors when package.json isn't exported
this could resolve #244 and also should get rid of errors that package.json isn't exported in general as resolveDependencyData falls back to a filesystem read - and even if it isn't exported, npm packages do always contain their package.json .
Note: before merging we should check performance and make sure it works the way we expect it to.
Some libraries (eg carbon-components-svelte) ship both compiled and uncompiled code, svelte field must take precedence in this case.
( related: carbon-design-system/carbon-components-svelte#991 )