fix: ignore protocol when resolve svelte field #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Dec 13, 2021
benmccann
approved these changes
Dec 13, 2021
Conduitry
reviewed
Dec 13, 2021
5 tasks
Conduitry
approved these changes
Dec 13, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the CI issue in sveltejs/kit#3034 where the
node:protocol was messing with resolving thesveltefield of package.json. Addingnode-fetch, Vite's scanner seems to resolve its nested imports using Vite plugin'sresolveId, and because we're usingenforce: "pre", we encounter this scenario before Vite's default resolver, which would've handled this.I'm also not sure why it's resolving the nested imports, but at the meantime this addition looks fine as well.