Skip to content

Commit

Permalink
fix: bump axobject-query (#10167)
Browse files Browse the repository at this point in the history
fixes #8825
  • Loading branch information
dummdidumm authored Jan 15, 2024
1 parent bc5e578 commit 4901029
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 13 deletions.
5 changes: 5 additions & 0 deletions .changeset/gentle-needles-beg.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: bump `axobject-query`
2 changes: 1 addition & 1 deletion packages/svelte/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
"@types/estree": "^1.0.1",
"acorn": "^8.9.0",
"aria-query": "^5.3.0",
"axobject-query": "^3.2.1",
"axobject-query": "^4.0.0",
"code-red": "^1.0.3",
"css-tree": "^2.3.1",
"estree-walker": "^3.0.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
let props = {};
const dynamicTypeValue = "checkbox";
const dynamicAriaHiddenValue = "false";
const dynamicRole = "button";
const dynamicTypeValue = 'checkbox';
const dynamicAriaHiddenValue = 'false';
const dynamicRole = 'button';
</script>

<!-- should warn -->
Expand All @@ -31,6 +31,7 @@
<a href="http://x.y.z" on:click={noop}>foo</a>
<button on:click={noop} />
<select on:click={noop} />
<summary on:click={noop} />

<input type="button" on:click={noop} />
<input type={dynamicTypeValue} on:click={noop} />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@
<div role="tab" />
<div role="textbox" />
<div role="treeitem" aria-selected={true} />
<summary role="listitem" />

<!-- HTML elements attributed with a non-interactive role -->
<div role="alert" />
Expand Down Expand Up @@ -144,5 +143,6 @@
<menuitem role="listitem" />
<option class="foo" role="listitem" />
<select class="foo" role="listitem" />
<summary role="listitem" />
<textarea class="foo" role="listitem" />
<tr role="listitem" />
Original file line number Diff line number Diff line change
Expand Up @@ -639,9 +639,21 @@
"code": "a11y-no-interactive-element-to-noninteractive-role",
"end": {
"column": 28,
"line": 144
"line": 143
},
"message": "A11y: <menuitem> cannot have role 'listitem'",
"start": {
"column": 0,
"line": 143
}
},
{
"code": "a11y-no-interactive-element-to-noninteractive-role",
"end": {
"column": 38,
"line": 144
},
"message": "A11y: <option> cannot have role 'listitem'",
"start": {
"column": 0,
"line": 144
Expand All @@ -653,7 +665,7 @@
"column": 38,
"line": 145
},
"message": "A11y: <option> cannot have role 'listitem'",
"message": "A11y: <select> cannot have role 'listitem'",
"start": {
"column": 0,
"line": 145
Expand All @@ -662,10 +674,10 @@
{
"code": "a11y-no-interactive-element-to-noninteractive-role",
"end": {
"column": 38,
"column": 27,
"line": 146
},
"message": "A11y: <select> cannot have role 'listitem'",
"message": "A11y: <summary> cannot have role 'listitem'",
"start": {
"column": 0,
"line": 146
Expand Down
8 changes: 4 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 4901029

Please sign in to comment.