Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preload in lib template #9863

Merged
merged 3 commits into from
May 8, 2023
Merged

Conversation

elliott-with-the-longest-name-on-github
Copy link
Contributor

Closes #9859

I couldn't immediately think of a reason we weren't doing this, so I just went ahead and added it. If there's a legit issue with adding it, we can just close this and the associated issue.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented May 7, 2023

🦋 Changeset detected

Latest commit: 684bacd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann
Copy link
Member

it seems a bit aggressive to me as it creates more load on the server. I personally like the current default of opting into it

@dummdidumm
Copy link
Member

We current default makes for faster pages, "falling into the pit of success" etc - it's also consistent with the other templates that way

@dummdidumm dummdidumm merged commit 7a2a583 into master May 8, 2023
@dummdidumm dummdidumm deleted the elliott/preload-on-lib-template branch May 8, 2023 07:44
@github-actions github-actions bot mentioned this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data-sveltekit-preload-data="hover" not present on body in lib template
3 participants