Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Switch default ESLint plugin from eslint-plugin-svelte3 to eslint-plugin-svelte #9749

Merged
merged 8 commits into from
Apr 25, 2023
Merged

chore: Switch default ESLint plugin from eslint-plugin-svelte3 to eslint-plugin-svelte #9749

merged 8 commits into from
Apr 25, 2023

Conversation

baseballyama
Copy link
Member

@baseballyama baseballyama commented Apr 22, 2023 •
edited
Loading

close: #9342
close: #6847

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9b5e373

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-svelte Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@baseballyama
Copy link
Member Author

@ota-meshi Could you please review the ESLint config?🙏

ota-meshi
ota-meshi reviewed Apr 23, 2023
View reviewed changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR! I made one comment.

packages/create-svelte/shared/+eslint+prettier+typescript/.eslintrc.cjs Outdated Show resolved Hide resolved
packages/create-svelte/shared/+eslint+typescript/.eslintrc.cjs Outdated Show resolved Hide resolved
baseballyama and others added 2 commits April 23, 2023 15:03
@baseballyama @ota-meshi
Update packages/create-svelte/shared/+eslint+prettier+typescript/.esl…
6e2f206 
…intrc.cjs

Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@baseballyama @ota-meshi
Update packages/create-svelte/shared/+eslint+typescript/.eslintrc.cjs
8364fe2 
Co-authored-by: Yosuke Ota <otameshiyo23@gmail.com>
@baseballyama baseballyama requested a review from dummdidumm April 23, 2023 06:05
@baseballyama baseballyama mentioned this pull request Apr 23, 2023
Merged
@baseballyama @Conduitry
Update .changeset/curly-moons-sin.md
9b5e373 
Co-authored-by: Conduitry <git@chor.date>
@baseballyama baseballyama requested a review from Conduitry April 24, 2023 01:08
@ota-meshi ota-meshi mentioned this pull request Apr 24, 2023
Closed
3 tasks
@baseballyama @benmccann
Update .changeset/curly-moons-sin.md
14cb64d 
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@eltigerchino
Copy link
Member

eltigerchino commented Apr 25, 2023 •
edited
Loading

I'm currently using the eslint config in this PR in a typescript project and can't seem to get eslint working for the svelte.config.js file. Can anyone else confirm if this is working?

@baseballyama
Copy link
Member Author

Hum...
In my local, I can see ESLint warning...

image

@eltigerchino
Copy link
Member

eltigerchino commented Apr 25, 2023 •
edited
Loading

Hum... In my local, I can see ESLint warning...

image

Ah shoot. I must have something incorrectly configured then. Thank you for confirming!
Is an unknown reference in JS something that should be covered by eslint?
CleanShot 2023-04-25 at 12 54 46@2x

dummdidumm
dummdidumm approved these changes Apr 25, 2023
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dummdidumm dummdidumm merged commit e46e669 into sveltejs:master Apr 25, 2023
@github-actions github-actions bot mentioned this pull request Apr 25, 2023
Merged
@dummdidumm dummdidumm mentioned this pull request Apr 26, 2023
Open
@polyzen
Copy link

polyzen commented Apr 28, 2023

BTW I think ignorePatterns: ['*.cjs'] can be removed because it seems it was only there to silence "moaning about require() calls in these files".

@baseballyama baseballyama mentioned this pull request Apr 28, 2023
Merged
5 tasks
@baseballyama baseballyama deleted the chore/eslint-plugin branch April 28, 2023 10:52
dummdidumm added a commit that referenced this pull request Apr 28, 2023
@baseballyama @dummdidumm
fix: remove obsolete ignorePatterns: ['*.cjs'] from template `.esli…
e3cfe2b 
…ntrc.cjs` (#9797)

mentioned in #9749 that it's no longer necessary

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@Webifi Webifi mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benmccann benmccann benmccann left review comments

@ota-meshi ota-meshi ota-meshi approved these changes

@dummdidumm dummdidumm dummdidumm approved these changes

@Conduitry Conduitry Awaiting requested review from Conduitry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eslint-plugin-svelte3 appears unmaintained, eslint-plugin-svelte looks better Switch default eslint plugin
7 participants
@baseballyama @eltigerchino @polyzen @benmccann @dummdidumm @ota-meshi @Conduitry