Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add actionResult option in handle hook to change form result #9682

Closed
wants to merge 2 commits into from

Conversation

qurafi
Copy link

@qurafi qurafi commented Apr 17, 2023

Closes #9676

Allow users to return form action result from handle hook using:resolve(event, {actionResult: ...})

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023

🦋 Changeset detected

Latest commit: ca47229

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

Thank you for the PR. I don't think this is the way to go though — as far as I can see this doesn't give you a way to replace form but not to modify/inspect it, which doesn't seem all that flexible. I think it's much more likely that if we were to add a feature like this, we'd have something like a handleAction hook, similar to the proposed handleLoad hook in #9542.

On a process note, the PR template includes the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs

The key word here is 'discussed' — merely opening an issue doesn't qualify :) PRs for new features like this are much more likely to be merged if they're the result of a conversation about how they should be designed! As things stand I'm not really sure what the purpose of this feature is, so I'm going to close this and ask for clarification on #9676.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a way to intercept and change form action result in handle hook
2 participants