Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: restore bug reporting section of readme #9292

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

benmccann
Copy link
Member

This is basically the only place ssr-svelte is documented and bugs won't reproduce if you use the standard template, which means even for advanced users there's no way to understand how to report a bug other than this documentation.

it was accidentally removed in #8109

reverts #9094

@Rich-Harris
Copy link
Member

Most Vite bugs we encounter are nothing to do with Svelte or SSR. Typically when I'm reproing something it'll look more like this https://github.com/Rich-Harris/vite-env-reload

@benmccann
Copy link
Member Author

I don't know if I'd agree, but regardless of the relative number having a template probably eases the reporting and certainly some are SSR-related so it makes sense to use the SSR template.

@Rich-Harris
Copy link
Member

I just don't think that's true. The issue where you linked to this PR, for example — creating a project with the ssr-svelte template would be a waste of time, because the issue is entirely to do with how Vite handles workspace dependencies in a monorepo.

All we're doing with these instructions is creating another variant — it doesn't create a simpler repro for Vite maintainers in the case where it's a Vite-specific bug, and it makes it harder for us to diagnose the problem and work on a fix when SvelteKit is at fault. I don't see the value.

@benmccann
Copy link
Member Author

The issue where you linked to this PR, for example — creating a project with the ssr-svelte template would be a waste of time, because the issue is entirely to do with how Vite handles workspace dependencies in a monorepo.

You could not reproduce that issue with a vanilla Vite template. Are you suggesting the issue filed in the Vite repo should use the SvelteKit template? I'm not necessarily against that, but I'd want to check with the Vite maintainers what their preference is

it makes it harder for us to diagnose the problem and work on a fix when SvelteKit is at fault

How could SvelteKit be at fault if it's reproducing with the ssr-svelte template?

@Rich-Harris
Copy link
Member

Are you suggesting the issue filed in the Vite repo should use the SvelteKit template?

No, I'm suggesting that the issue filed in the Vite repro shouldn't involve Svelte at all. It should look more like these:

But I'm not confident we can explain how to do that — the people who are capable of creating those repros will do so anyway

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants