Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] error rework cleanup #6675

Merged
merged 1 commit into from
Sep 8, 2022
Merged

[fix] error rework cleanup #6675

merged 1 commit into from
Sep 8, 2022

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 8, 2022

See here if you want to know how to migrate: #6586

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

- add missing changeset, closes #6664
- enhance docs, closes #6669
- fix fallback message in client
@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

🦋 Changeset detected

Latest commit: afdf41d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 31f829d into master Sep 8, 2022
@Rich-Harris Rich-Harris deleted the error-rework-cleanup branch September 8, 2022 22:00
@github-actions github-actions bot mentioned this pull request Sep 8, 2022
/** @type {import('@sveltejs/kit').HandleClientError} */
export function handleError({ error, event }) {
// example integration with https://sentry.io/
Sentry.captureException(error, { event });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't do:

Sentry.captureException(error, { event: event });

You need to do:

Sentry.captureException(error, {
    extra: { event: event },
});

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants