Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jsconfig in JS projects #510

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Use jsconfig in JS projects #510

merged 1 commit into from
Mar 13, 2021

Conversation

dummdidumm
Copy link
Member

Fixes #506
Also reorganized ts template specific files a little. There's no a dedicated folder for TS files from which they are copied into the template. This separates the file contents from the copy-logic.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

Fixes #506
Also reorganized ts template specific files a little. There's no a dedicated folder for TS files from which they are copied into the template. This separates the file contents from the copy-logic.
@dummdidumm dummdidumm merged commit 97b7ea4 into master Mar 13, 2021
@dummdidumm dummdidumm deleted the fix-506 branch March 13, 2021 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't include tsconfig.json in non-TypeScript projects
1 participant