Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root devdeps #5012

Merged
merged 8 commits into from
May 23, 2022
Merged

Root devdeps #5012

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fc8b37b
move devDeps to root
Rich-Harris May 21, 2022
96aaee6
remove some more stuff
Rich-Harris May 21, 2022
66f0628
more
Rich-Harris May 21, 2022
274cd91
move @playwright/test
Rich-Harris May 21, 2022
169bc1d
update svelte
mrkishi May 21, 2022
9539902
restore @types/node pinned to v16
mrkishi May 22, 2022
a81053d
major versions are pinned with caret, dummy
mrkishi May 22, 2022
7723deb
merge master -> root-devdeps
Rich-Harris May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,22 +23,35 @@
"homepage": "https://github.com/sveltejs/kit#readme",
"devDependencies": {
"@changesets/cli": "^2.18.1",
"@playwright/test": "^1.21.0",
"@rollup/plugin-commonjs": "^21.0.1",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.0.6",
"@rollup/plugin-replace": "^4.0.0",
"@sveltejs/eslint-config": "github:sveltejs/eslint-config#v5.8.0",
"@svitejs/changesets-changelog-github-compact": "^0.1.1",
"@types/node": "~16.11.36",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why tilde instead of caret?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how @types/node versions correspond to Node versions. If we're saying we support Node 16+, we should make sure we only have Node 16.0 types available, and not those from any later versions of Node 16. I don't know how we enforce this. Would that be ~16.0.0?

If that's the purpose of the tilde, and if that's how the @types/node versions work, we should make sure we don't bring in types for versions of Node we don't support (so that the typechecking can yell at us immediately if we use unsupported features), so that's why no caret, but also ~16.11 isn't what we want to be depending on either.

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

Copy link
Member

@mrkishi mrkishi May 22, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Errr, wait. I completely confused things in my head. I intended to use ~ for Typescript, not Node... This was me failing to diff Rich's changes on top of the ones I had already done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @types/node@16.11.x is types for Node 16.11.x (is it?), then we don't want to use those types, as they would include features added after Node 16.0, and we're claiming SvelteKit works with any version of Node 16+ (which would include Node 16.0). If that's how versioning on @types/node indeed works, it would be nice to be warned by the typechecker that we are using features of Node that we shouldn't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since they're manually maintained, there's a best-effort process to match the major and minor versions with Node's. I'm not sure they backport fixes to previous minor versions when a gap is found late (eg. 16.1 backported to 16.0), though.

We could make it ~16.0, but maybe we need some CI tests to make sure it doesn't get changed accidentally. Apparently Svelte's =8 didn't last 3 months, eh, Conduitry? 😆

I joke, but all package managers encourage us to update even if pinned to exact versions when updating post-package.json, so a CI check isn't that ridiculous.

"@typescript-eslint/eslint-plugin": "^5.5.0",
"@typescript-eslint/parser": "^5.5.0",
"cross-env": "^7.0.3",
"eslint": "^8.3.0",
"eslint-plugin-import": "^2.25.3",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-svelte3": "^4.0.0",
"port-authority": "^1.1.2",
"prettier": "^2.5.0",
"prettier-plugin-svelte": "^2.5.0",
"rimraf": "^3.0.2",
"rollup": "^2.60.2",
"sirv": "^2.0.0",
"svelte": "^3.48.0",
"svelte-check": "^2.5.0",
"svelte-preprocess": "^4.9.8",
"svelte2tsx": "~0.5.0",
"tiny-glob": "^0.2.9",
"turbo": "^1.2.6",
"typescript": "~4.6.2"
"typescript": "~4.6.2",
"uvu": "^0.5.2"
},
"packageManager": "pnpm@7.1.2",
"engines": {
Expand Down
4 changes: 0 additions & 4 deletions packages/adapter-auto/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,5 @@
"@sveltejs/adapter-cloudflare": "workspace:*",
"@sveltejs/adapter-netlify": "workspace:*",
"@sveltejs/adapter-vercel": "workspace:*"
},
"devDependencies": {
"@types/node": "^14.14.20",
"typescript": "^4.6.2"
}
}
4 changes: 1 addition & 3 deletions packages/adapter-cloudflare-workers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@
"esbuild": "^0.14.29"
},
"devDependencies": {
"@cloudflare/kv-asset-handler": "^0.2.0",
"@types/node": "^14.14.20",
"typescript": "^4.6.2"
"@cloudflare/kv-asset-handler": "^0.2.0"
}
}
4 changes: 1 addition & 3 deletions packages/adapter-cloudflare/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,7 @@
"worktop": "0.8.0-next.14"
},
"devDependencies": {
"@types/node": "^14.14.20",
"@types/ws": "^8.5.3",
"typescript": "^4.6.2"
"@types/ws": "^8.5.3"
},
"publishConfig": {
"access": "public"
Expand Down
10 changes: 1 addition & 9 deletions packages/adapter-netlify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,6 @@
},
"devDependencies": {
"@netlify/functions": "^1.0.0",
"@rollup/plugin-commonjs": "^21.0.0",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.0.5",
"@sveltejs/kit": "workspace:*",
"@types/node": "^14.14.20",
"rimraf": "^3.0.2",
"rollup": "^2.58.0",
"typescript": "^4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
}
}
10 changes: 1 addition & 9 deletions packages/adapter-node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,18 +35,10 @@
"tiny-glob": "^0.2.9"
},
"devDependencies": {
"@rollup/plugin-json": "^4.1.0",
"@sveltejs/kit": "workspace:*",
"@types/compression": "^1.7.2",
"@types/node": "^14.14.20",
"c8": "^7.10.0",
"compression": "^1.7.4",
"node-fetch": "^3.1.0",
"polka": "^1.0.0-next.22",
"rimraf": "^3.0.2",
"rollup": "^2.60.2",
"sirv": "^2.0.0",
"typescript": "^4.6.2",
"uvu": "^0.5.2"
"polka": "^1.0.0-next.22"
}
}
9 changes: 1 addition & 8 deletions packages/adapter-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,13 +28,6 @@
"tiny-glob": "^0.2.9"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"@types/node": "^14.14.20",
"playwright-chromium": "^1.21.0",
"port-authority": "^1.1.2",
"sirv": "^2.0.0",
"svelte": "^3.44.2",
"typescript": "^4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
}
}
3 changes: 1 addition & 2 deletions packages/adapter-static/test/apps/prerendered/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@
"start": "../../../../kit/svelte-kit.js start"
},
"devDependencies": {
"@sveltejs/kit": "next",
"svelte": "^3.43.0"
"@sveltejs/kit": "next"
},
"type": "module"
}
3 changes: 1 addition & 2 deletions packages/adapter-static/test/apps/spa/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@
"devDependencies": {
"@sveltejs/adapter-node": "next",
"@sveltejs/kit": "next",
"sirv-cli": "^2.0.2",
"svelte": "^3.43.0"
"sirv-cli": "^2.0.2"
},
"type": "module"
}
2 changes: 1 addition & 1 deletion packages/adapter-static/test/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import http from 'http';
import { fileURLToPath } from 'url';
import * as ports from 'port-authority';
import sirv from 'sirv';
import { chromium } from 'playwright-chromium';
import { chromium } from '@playwright/test';
import * as uvu from 'uvu';

/**
Expand Down
4 changes: 1 addition & 3 deletions packages/adapter-vercel/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,6 @@
"esbuild": "^0.14.29"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"@types/node": "^14.14.20",
"typescript": "^4.6.2"
"@sveltejs/kit": "workspace:*"
}
}
8 changes: 1 addition & 7 deletions packages/create-svelte/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,12 @@
"prompts": "^2.4.2"
},
"devDependencies": {
"@playwright/test": "^1.21.0",
"@sveltejs/kit": "workspace:*",
"@types/gitignore-parser": "^0.0.0",
"@types/prettier": "^2.4.2",
"@types/prompts": "^2.0.14",
"gitignore-parser": "^0.0.2",
"prettier": "^2.5.0",
"prettier-plugin-svelte": "^2.5.0",
"sucrase": "^3.20.3",
"svelte": "^3.44.2",
"svelte-preprocess": "^4.9.8",
"tiny-glob": "^0.2.9"
"sucrase": "^3.20.3"
},
"scripts": {
"build": "node scripts/build-templates",
Expand Down
17 changes: 1 addition & 16 deletions packages/kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,36 +16,21 @@
"vite": "^2.9.9"
},
"devDependencies": {
"@playwright/test": "^1.21.0",
"@rollup/plugin-replace": "^4.0.0",
"@types/connect": "^3.4.35",
"@types/cookie": "^0.5.0",
"@types/marked": "^4.0.1",
"@types/mime": "^2.0.3",
"@types/node": "^16.11.11",
"@types/sade": "^1.7.3",
"@types/set-cookie-parser": "^2.4.2",
"cookie": "^0.5.0",
"cross-env": "^7.0.3",
"devalue": "^2.0.1",
"eslint": "^8.3.0",
"kleur": "^4.1.4",
"locate-character": "^2.0.5",
"marked": "^4.0.5",
"mime": "^3.0.0",
"node-fetch": "^3.1.0",
"port-authority": "^1.1.2",
"rollup": "^2.60.2",
"selfsigned": "^2.0.0",
"set-cookie-parser": "^2.4.8",
"sirv": "^2.0.0",
"svelte": "^3.44.2",
"svelte-check": "^2.5.0",
"svelte-preprocess": "^4.9.8",
"svelte2tsx": "~0.5.0",
"tiny-glob": "^0.2.9",
"typescript": "^4.6.4",
"uvu": "^0.5.2"
"svelte": "^3.48.0"
},
"peerDependencies": {
"svelte": "^3.44.0"
Expand Down
6 changes: 1 addition & 5 deletions packages/kit/test/apps/amp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,7 @@
"devDependencies": {
"@sveltejs/amp": "workspace:*",
"@sveltejs/kit": "workspace:*",
"cross-env": "^7.0.3",
"purify-css": "^1.2.5",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2"
"purify-css": "^1.2.5"
},
"type": "module"
}
5 changes: 1 addition & 4 deletions packages/kit/test/apps/basics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,7 @@
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"cross-env": "^7.0.3",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2"
"marked": "^4.0.5"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/apps/options-2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@
},
"devDependencies": {
"@sveltejs/adapter-node": "workspace:*",
"@sveltejs/kit": "workspace:*",
"cross-env": "^7.0.3",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/apps/options/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,7 @@
"test:build": "playwright test"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"cross-env": "^7.0.3",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/prerendering/basics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
"test": "npm run build && uvu test"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/prerendering/disabled/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
"test": "npm run build"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/prerendering/options/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
"test": "npm run build && uvu test"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/prerendering/paths-base/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,7 @@
"test": "npm run build && uvu test"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
6 changes: 1 addition & 5 deletions packages/kit/test/prerendering/trailing-slash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,7 @@
"check": "tsc && svelte-check"
},
"devDependencies": {
"@sveltejs/kit": "workspace:*",
"svelte": "^3.43.0",
"svelte-check": "^2.5.0",
"typescript": "~4.6.2",
"uvu": "^0.5.2"
"@sveltejs/kit": "workspace:*"
},
"type": "module"
}
Loading