Add option to disable client-side rendering #361
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* start converting everything to ESM * more stuff * chore: finish ESM conversion (#360) * fix(test): manually control `UVU_QUEUE` positions; Have to replicate the `uvu` internals since all internal loader/iterator logic is bypassed. * fix: force `UVU_QUEUE` values * chore: add `context.reset` method; - chasing unterminated process * fix(kit): return `snowpack.shutdown` promise - so that `dev.close` is await'able * fix(runner): manually exit process; - also part of what uvu cli does; derp * chore: convert "test/apps/basics" fixture * chore: convert "test/apps/options" fixture * bump meriyah * all tests passing, i think? * simplify * get CLI working * brute force Co-authored-by: Luke Edwards <luke.edwards05@gmail.com>
|
gahhh. I borked this branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements one of the options suggested in #231
I was originally writing this because I have an app that can be statically rendered and Kit is including a bunch of JS and re-rendering it on the client after it's already been server-rendered, which isn't really necessary. However, I realized I have some interactivity, so I won't be able to do this. Or maybe I'll just write the interactive part as an external script for now. I guess the real solution is just to wait for hydration improvements