[fix] polyfill fetch before running any app code #3400
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3343
Before this change, referencing
fetch
at the top level ofhooks.js
would throwReferenceError: fetch is not defined
on platforms without native fetch. This is because we were polyfillingfetch
after importing the compiled app, at which point it was too late. It looks like this was introduced with the adapter overhaul, where we stopped using esbuild'sinject
option.To fix this, I moved the call to
__fetch_polyfill
inside its own module so that it would run before importing the app. I had to give it its own Rollup entry (in the adapters that use Rollup) so that it remained separate and import order was preserved.I tested this locally with the node adapter and it fixed the linked issue. I also locally generated bundles with the Netlify and Vercel adapter and verified that
__fetch_polyfill
is called before any app code.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpx changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0