-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Todo delete button not disabling while waiting for API response #2172
Fix Todo delete button not disabling while waiting for API response #2172
Conversation
🦋 Changeset detectedLatest commit: 636eb96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. thank you! I really wanted to get this fixed before announcing 1.0 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
packages/create-svelte/templates/default/src/routes/todos/index.svelte
Outdated
Show resolved
Hide resolved
packages/create-svelte/templates/default/src/routes/todos/index.svelte
Outdated
Show resolved
Hide resolved
…x.svelte Co-authored-by: Ignatius Bagus <ignatius.mbs@gmail.com>
@benmccann Thank you for taking the time to open #2100, that's where I found it :) From the description I thought it wouldn't need to be noted in a changelog since it's just the demo app, so I didn't create the changeset. @ignatiusmb Thanks for the suggestions! I've never used TS so I wasn't sure if an attribute that isn't always present should be in the type definition. |
No worries. I don't normally add a changelog for stuff in the |
#1564 - currently the todo's in the demo app suffer from a bug where you can click delete on a todo while the first delete is still pending.
This allows multiple delete requests to be sent, HTTP 500 errors to be received (https://github.com/sveltejs/api.svelte.dev/blob/master/src/routes/todos.ts#L46) and the todo to never visually disappear.