[feat] Ignore adapter build files #1924
replace \n by EOL
- Loading branch information
commit 99fac6303d954be51e5e87b903384a1a01f7c914
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ import { SVELTE_KIT } from '../constants.js'; | |
| import { copy, rimraf, mkdirp } from '../filesystem/index.js'; | ||
| import { prerender } from './prerender.js'; | ||
| import fs from 'fs'; | ||
| import { EOL } from 'os'; | ||
|
|
||
| /** | ||
| * | ||
|
|
@@ -59,14 +60,13 @@ export function get_utils({ cwd, config, build_data, log }) { | |
| const file = fs.readFileSync(target, { encoding: 'utf-8' }); | ||
| const lines = file.split(/\r?\n/); | ||
| const new_lines = new Set(patterns); | ||
| // remove repeated lines | ||
| for (const line of lines) { | ||
| // this will prevent commented ignores to be reinserted | ||
| new_lines.delete(line.replace(/#\s*/, '')); | ||
| } | ||
| if (new_lines.size === 0) continue; | ||
| fs.writeFileSync(target, [...lines, ...new_lines].join(EOL)); | ||
|
There was a problem hiding this comment. should this detect what type of line endings are used in the file and preserve that? There was a problem hiding this comment. No, its the end of line of the platform the code is being executed on There was a problem hiding this comment. exactly, but it is possible that the native EOL is different from the style thats used in the file. sveltekit itself for example forces LF: Line 4 in f360a9f prefering the native EOL vs the existing eol in the file itself also leads to a bigger diff and may cause problems if checked in and then checked out on other platforms. |
||
| if (log) this.log.success(`Updated ${target}`); | ||
| } | ||
| } | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method is a lot simpler. I like it.