Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make <build> route exclusion rule only exclude static assets #13411

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

Begad666
Copy link
Contributor

@Begad666 Begad666 commented Feb 3, 2025

Fixes #13385

The original rule of /_app/* broke apps with pre-rendered pages and pages using dynamic environment variables simultaneously, because it excludes /_app/env.js, which is loaded in pre-rendered pages. This fixes it by only excluding the assets generated by Vite.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: f6b8665

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@eltigerchino eltigerchino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@eltigerchino eltigerchino merged commit a09db8c into sveltejs:main Feb 4, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Feb 4, 2025
@Begad666 Begad666 deleted the cloudflare-adapter-fix branch February 4, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config.kit.env.publicModule option does not exist
2 participants