Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more Svelte 5 conversion #12871

Merged
merged 8 commits into from
Oct 25, 2024
Merged

docs: more Svelte 5 conversion #12871

merged 8 commits into from
Oct 25, 2024

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Oct 23, 2024

closes sveltejs/svelte.dev#549

fixes some leftovers, adds a few callouts to legacy syntax

fixes some leftovers, adds a few callouts to legacy syntax
Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: 6e7b30f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

eltigerchino
eltigerchino previously approved these changes Oct 25, 2024
@eltigerchino eltigerchino dismissed their stale review October 25, 2024 05:29

see suggestions

dummdidumm and others added 3 commits October 25, 2024 08:23
Co-authored-by: Willow (GHOST) <ghostdevbusiness@gmail.com>
Co-authored-by: Sri Senthil Balaji J <50240805+SymphonySimper@users.noreply.github.com>
Co-authored-by: Tee Ming <chewteeming01@gmail.com>
@SymphonySimper
Copy link
Contributor

SymphonySimper commented Oct 25, 2024

sveltejs/svelte.dev#549 (comment)

Couple of sections still seems to use <slot></slot> | <slot /> instead of {@render children()}.

https://svelte.dev/docs/kit/routing
https://svelte.dev/docs/kit/load#Layout-data
https://svelte.dev/docs/kit/advanced-routing

Can this be addressed as well?

@eltigerchino
Copy link
Member

sveltejs/svelte.dev#549 (comment)

Couple of sections still seems to use <slot></slot> | <slot /> instead of {@render children()}.
svelte.dev/docs/kit/routing
svelte.dev/docs/kit/load#Layout-data
svelte.dev/docs/kit/advanced-routing

Can this be addressed as well?

Yes, these also contain export let data. Good find.

@SymphonySimper
Copy link
Contributor

SymphonySimper commented Oct 25, 2024

Yes, these also contain export let data. Good find.

Thanks! All most all of the export let data has been fixed. The only one I could find is at 90-adapter-vercel.md.

@SymphonySimper
Copy link
Contributor

let next = $derived(data.posts[index - 1];)+++

Shouldn't this be index + 1 for next? And the ; should be outside of the brackets.
Suggested Change:

- let next = $derived(data.posts[index - 1];)+++
+ let next = $derived(data.posts[index + 1]);+++

@eltigerchino eltigerchino added the documentation Improvements or additions to documentation label Oct 25, 2024
@eltigerchino
Copy link
Member

eltigerchino commented Oct 25, 2024

This PR fixes the lint error for src/exports/vite/public.d.ts too.

@dummdidumm dummdidumm merged commit bd82819 into main Oct 25, 2024
10 checks passed
@dummdidumm dummdidumm deleted the docs-fixes branch October 25, 2024 11:45
dummdidumm added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update example for Svelte 5
5 participants