Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tsconfig includes should cover svelte.config.js #11886

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

benmccann
Copy link
Member

I was unable to setup https://typescript-eslint.io/rules/no-misused-promises/ in a SvelteKit project without this. I might have been able to tweak the esconfig settings to get it to work, but either way it seemed like the svelte.config.js should be there if the vite.config.js is there

@benmccann benmccann requested a review from dummdidumm February 23, 2024 05:49
Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: 01a3a7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Looks good to me but can't help but wonder why we didn't do it previously - did we omit it on purpose to not pull in certain global type definitions which pollute the namespace? I'm not sure.

@benmccann
Copy link
Member Author

I just went through the file history and can't see that we ever removed it, so I'm going to assume it was just overlooked.

@benmccann benmccann merged commit f6f9e70 into main Feb 26, 2024
13 checks passed
@benmccann benmccann deleted the svelte-config branch February 26, 2024 15:37
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
@thenbe
Copy link
Contributor

thenbe commented Feb 26, 2024

I was unable to setup typescript-eslint.io/rules/no-misused-promises in a SvelteKit project without this.

I've encountered similar(?) weirdness while trying to add type-aware linting to this example repo. In my case, the current workaround is to ensure the $DIR in pnpm eslint $DIR has an immediate child that ends in .svelte. Otherwise type-aware linting fails for all svelte files.

I'm still having trouble identifying the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants