Skip to content

Commit

Permalink
always generate 404.html (#9294)
Browse files Browse the repository at this point in the history
* add fallback option to adapter-cloudflare

* always generate fallback

* Update packages/adapter-cloudflare/index.js

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>

* format

---------

Co-authored-by: ajgeiss0702 <ajgeiss72@gmail.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
  • Loading branch information
3 people authored Mar 3, 2023
1 parent 557422b commit e59b2fc
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
5 changes: 5 additions & 0 deletions .changeset/long-lobsters-love.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-cloudflare': minor
---

feat: generate `404.html`
7 changes: 5 additions & 2 deletions packages/adapter-cloudflare/index.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { writeFileSync } from 'node:fs';
import { posix } from 'node:path';
import * as path from 'node:path';
import { fileURLToPath } from 'node:url';
import * as esbuild from 'esbuild';

Expand All @@ -16,11 +16,14 @@ export default function (options = {}) {
builder.rimraf(tmp);
builder.mkdirp(tmp);

// generate 404.html first which can then be overridden by prerendering, if the user defined such a page
await builder.generateFallback(path.join(dest, '404.html'));

const dest_dir = `${dest}${builder.config.kit.paths.base}`;
const written_files = builder.writeClient(dest_dir);
builder.writePrerendered(dest_dir);

const relativePath = posix.relative(tmp, builder.getServerDirectory());
const relativePath = path.posix.relative(tmp, builder.getServerDirectory());

writeFileSync(
`${tmp}/manifest.js`,
Expand Down

0 comments on commit e59b2fc

Please sign in to comment.