Skip to content

Commit

Permalink
Remove comments from undesired location
Browse files Browse the repository at this point in the history
  • Loading branch information
hariombalhara committed Jun 20, 2021
1 parent 86c109e commit 5e25674
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/kit/src/core/create_manifest_data/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,10 @@ export default function create_manifest_data({ config, output, cwd = process.cwd
/**
* @type {string[]}
*/
let exclusions = config.kit.serviceWorker.exclude || [];
const exclusions = config.kit.serviceWorker.exclude || [];

// .DS_STORE files are automatically removed to keep the compatiblity
exclusions = [...exclusions, '**/.DS_STORE'];
exclusions.push('**/.DS_STORE');

/**
* @type {string[]}
Expand Down
3 changes: 0 additions & 3 deletions packages/kit/types/config.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,6 @@ export type Config = {
hostHeader?: string;
hydrate?: boolean;
serviceWorker?: {
// Glob patterns relative to `files.assets` dir. Files matching this would not be available in $service-worker.files
// e.g. if `files.assets` has value `static` then ['og-tags-images/**/*'] would match all files under `static/og-tags-images` dir.
// As og-tags-images are never loaded by a normal client(browser), they can be comfortably skipped from here.
exclude?: string[];
};
package?: {
Expand Down

0 comments on commit 5e25674

Please sign in to comment.