Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: simple testing library #275
feat: simple testing library #275
Changes from 56 commits
5e22384
95ff386
71e47f2
7e0f152
974e5ad
8570940
809a72f
3e6f6bd
0c86f37
665ead0
6446e59
53934db
d3ef737
e398dc2
8068dfc
4b2f036
0a0ba1a
cd1a56d
ed32699
d40929a
36939bb
c1b61be
7ae9ad9
1379621
6adea4d
266fea4
6a139e2
0fa007f
d417939
19e80da
b2af1bb
6d96a56
fa0a992
a9bbe4f
a76f89b
55afcbe
e6386a7
6a1d29f
1e5be34
1e676fe
0a56d26
f6523d4
5870036
677fbb0
6e9360c
7181351
d98c630
9aa59cf
dd141e7
d4794f0
50fde5c
2b98217
8e00672
9526fee
ebe7812
ed81a57
a3baf83
987b1e8
650ede7
047c549
fe810a5
25cadb6
88f9473
9d5b6b2
ef2df6e
c3aa2fc
1c095d6
57ab58e
88bf2ec
fc72e9a
77fd78e
c01e72e
b6d91be
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of those files look identical to me, why duplicate them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import specifiers for the demo are different. Though, we could simplify it to just modify the contents of the file like we do in the mdsvex test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have guessed these would come from the core package so that we can separately version the CLI and core package
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did notice this in #32. Is this worth a bug report to the
vitest
team?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should, yea. just haven't gotten around to making a repro for it yet