Fix #11 - randomness component evaluating to 0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll to Time(ulid) - Change all timing calls to use chrono time points to ensure ms units (not seconds) are always encoded as the timestamp portion - Fix problems using time_t on 32 bit systems by explicitly making this an int64_t
bdraco
added a commit
to Bluetooth-Devices/ulid-transform
that referenced
this pull request
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #11 by static casting the entire expression to ensure the evaluation will properly be between 0-255.
I tested this fix locally in an application to confirm it works, and I believe the change won't break #7.