Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make player limit configurable independent of server size #4685

Closed
STK-Waldlaubsaengernest opened this issue Nov 30, 2021 · 1 comment · Fixed by #4689
Closed

Make player limit configurable independent of server size #4685

STK-Waldlaubsaengernest opened this issue Nov 30, 2021 · 1 comment · Fixed by #4689
Assignees
@STK-Waldlaubsaengernest
Labels
C:Networking P2: major R: fixed T: enhancement
Milestone
1.4

Comments

@STK-Waldlaubsaengernest
Copy link
Contributor

Description

A server with more slots than players in game can be useful to allow waiting players to spectate and chat. Currently, this is only possible for servers with exactly 10 players in soccer or battle mode. I would like to have this feature for any number of players (<= 10) and for any game mode.

Configuration

STK version: STK latest Git version (1.3 #ea5aabde0)

Additional information

Some further ideas related to this issue:

  1. Always spectating players (/spectate 1) should not count into the limit
  2. It should not be possible to bypass the limit by parallel live join
@STK-Waldlaubsaengernest
Copy link
Contributor Author

You can assign the issue to me, I can implement it.

STK-Waldlaubsaengernest added a commit to STK-Waldlaubsaengernest/stk-code that referenced this issue Dec 5, 2021
@STK-Waldlaubsaengernest
Make limit of players in game configurable (supertuxkart#4685)
97eb45b
STK-Waldlaubsaengernest added a commit to STK-Waldlaubsaengernest/stk-code that referenced this issue Dec 6, 2021
@STK-Waldlaubsaengernest
Update player list if state changes to WAITING_FOR_START_GAME (supert…
a0cc6c9 
…uxkart#4685)
Merged
@Alayan-stk-2 Alayan-stk-2 added this to the 1.4 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@STK-Waldlaubsaengernest STK-Waldlaubsaengernest

Labels
C:Networking P2: major R: fixed T: enhancement
Projects
None yet
Milestone
1.4
Development

Successfully merging a pull request may close this issue.

Make limit of players in game configurable (#4685) STK-Waldlaubsaengernest/stk-code
2 participants
@Alayan-stk-2 @STK-Waldlaubsaengernest