Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong difficulty displayed in end race screen if comparing ghosts with difficulty #3849

Closed
Wuzzy2 opened this issue Apr 16, 2019 · 0 comments
Closed

Wrong difficulty displayed in end race screen if comparing ghosts with difficulty #3849

Wuzzy2 opened this issue Apr 16, 2019 · 0 comments
Labels
C:GUI P5: very minor No release will be postponed because of this R: fixed T: defect
Milestone
1.4

Comments

@Wuzzy2
Copy link

Wuzzy2 commented Apr 16, 2019

Description

If you compare ghosts with a different difficulty, the displayed difficulty in the end card (race results) is misleading.

Steps to reproduce

  • Start a replay and compare 2 ghosts that have a different difficulty (e.g. Expert vs SuperTux)
  • Watch the replay to the end, until the end card appears
  • Look at the end card

EXPECTED:
The end card shows the correct difficulties for all ghosts.

ACTUAL:
The end card only shows one difficulty.

Suggested fixes

Simple fix

If the ghost difficulties differ, display something different for the difficulty:

Difficulties: [lowest difficulty] to [highest difficulty]

(as a range)

Better fix

In the end card, show the difficulty for each ghost.

Video

https://www.youtube.com/watch?v=sjjWWtihdac

This is a comparison between Expert and SuperTux, but the end card only shows:

Difficulty: SuperTux

But it should show:

Difficulties: Expert to SuperTux

Config

Version: 0.10-rc1
Source: Git
@Alayan-stk-2 Alayan-stk-2 added C:GUI P5: very minor No release will be postponed because of this T: defect labels Apr 16, 2019
@Alayan-stk-2 Alayan-stk-2 added this to the 0.10.1 milestone Apr 16, 2019
@Alayan-stk-2 Alayan-stk-2 modified the milestones: 1.1, 2.0 Oct 19, 2019
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Nov 24, 2021
Add the display of ghosts difficulties in end race screen for replay …
15ff9d0 
…files with standard names (supertuxkart#3849)
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Nov 25, 2021
Add the display of ghosts difficulties in end race screen for replay …
4e67edb 
…files with standard names (supertuxkart#3849)
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Nov 25, 2021
Add the display of ghosts difficulties in end race screen for replay …
ba097bc 
…files with standard names (supertuxkart#3849)
@ldoyenard ldoyenard mentioned this issue Nov 25, 2021
Closed
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Dec 1, 2021
Displays ghost difficulties at the end screen of a replay (supertuxka…
4b23fb7 
…rt#3849)
@Benau Benau closed this as completed in 4a72a79 Dec 3, 2021
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Dec 8, 2021
Fix supertuxkart#3849
be16d24
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Dec 16, 2021
Upgrade of fix supertuxkart#4692 about ghost difficulties (origin sup…
d40073a 
…ertuxkart#3849)
ldoyenard pushed a commit to ldoyenard/stk-code that referenced this issue Jan 3, 2022
Upgrade v2 of fix supertuxkart#4692 about ghost difficulties (origin s…
3c09651 
…upertuxkart#3849)
@Alayan-stk-2 Alayan-stk-2 modified the milestones: 2.0, 1.4 Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:GUI P5: very minor No release will be postponed because of this R: fixed T: defect
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@Wuzzy2 @Alayan-stk-2