Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separates out installation for tests and fixes dependencies on frameworks #83

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

rishabhpoddar
Copy link
Contributor

@rishabhpoddar rishabhpoddar commented Mar 2, 2022

Summary of change

FIxes a bug where all frameworks dependencies needed to be added by the user.

Related issues

Test Plan

Added separate installation steps for each framework which is run when running auth-react and website tests

Documentation changes

None

Checklist for important updates

  • Changelog has been updated
  • coreDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in supertokens_python/constants.py
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In setup.py
    • In supertokens_python/constants.py
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If have added a new web framework, update the supertokens_python/utils.py file to include that in the FRAMEWORKS variable
  • If added a new recipe that has a User type with extra info, then be sure to change the User type in supertokens_python/types.py

@rishabhpoddar rishabhpoddar changed the title fixes: separates out installation for tests and fixes dependencies on frameworks fix: separates out installation for tests and fixes dependencies on frameworks Mar 2, 2022
@rishabhpoddar rishabhpoddar merged commit be3e8fc into 0.5 Mar 2, 2022
@rishabhpoddar rishabhpoddar deleted the framework-fix branch March 2, 2022 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant