Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for debug logging #64

Merged
merged 9 commits into from
Sep 30, 2024

Conversation

deepjyoti30-st
Copy link
Contributor

@deepjyoti30-st deepjyoti30-st commented Sep 26, 2024

Summary of change

  • This PR adds support for a debug option in the SDK that enabled debug logging through-out the SDK.
  • Fixes an issue with the pre-commit hook workflow failing

Test Plan

Testing the main effect

PS: Variable name was debug in my testing but I changed it to enableDebugLogs afterwards as you can see in the changes.

Documentation changes

(If relevant, please create a PR in our docs repo, or create a checklist here highlighting the necessary changes)

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
    • Along with the associated array in lib/src/version.dart
  • Changes to the version if needed
    • In pubspec.yaml
    • In lib/src/version.dart
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

@deepjyoti30-st deepjyoti30-st marked this pull request as ready for review September 27, 2024 12:02
lib/src/front-token.dart Outdated Show resolved Hide resolved
@rishabhpoddar rishabhpoddar merged commit a40eff1 into 0.6 Sep 30, 2024
3 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/add-support-for-debug-logging branch September 30, 2024 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants