Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle failed fetch error in multitenancy login methods #876

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ahielanravichandran
Copy link

@ahielanravichandran ahielanravichandran commented Jan 16, 2025

Description

Fixes the handling of "Failed to fetch" errors when loading dynamic login methods.

Changes

  • Removed error rethrowing in AuthPage and RoutingComponent
  • Added proper error handling in FeatureWrapper
  • Added error logging with proper TypeScript types

Testing plan

  1. Start the app with the backend server down
  2. Navigate to the login page
  3. Verify that the error is properly handled and logged
  4. Verify no infinite loops or unhandled promise rejections occur

Checklist for important updates

  • Changelog has been updated
  • frontendDriverInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In package.json
    • In package-lock.json
    • In lib/ts/version.ts
  • Had run npm run build-pretty
  • Had installed and ran the pre-commit hook
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.
  • If added a new recipe interface, then make sure that the implementation of it uses NON arrow functions only (like someFunc: function () {..}).
  • If I added a new recipe, I also added the recipe entry point into the size-limit section of package.json with the size limit set to the current size rounded up.
  • If I added a new recipe, I also added the recipe entry point into the rollup.config.mjs
  • If I added a new login method, I modified the list in lib/ts/types.ts
  • If I added a factor id, I modified the list in lib/ts/recipe/multifactorauth/types.ts

lib/ts/components/routingComponent.tsx Outdated Show resolved Hide resolved
lib/ts/components/featureWrapper.tsx Outdated Show resolved Hide resolved
lib/ts/components/routingComponent.tsx Outdated Show resolved Hide resolved
lib/ts/components/routingComponent.tsx Outdated Show resolved Hide resolved
1. Added a comment explaining why we are ignoring the exception in authpage.
2. Added proper translation function to construct these messages
3. Explicitly made this a boolean in featureWrapper
4. Default value set to undefined over empty string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants