-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MFA docs #763
Merged
Merged
MFA docs #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for admiring-bhabha-7b1be9 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of change
(A few sentences about this PR)
Related issues
Checklist
cd v2 && MODE=production npx docusaurus build
)Remaining TODOs for this PR
null
and explain what that meansLegacy MFA method does not need to worry about overwriting the session anymore. Decided not to do this cause it doesn't matter is users do this.getMFARequirementsForAuth
undefined
supported ingetMFARequirementsForAuth
?n
array is empty.?
from userContext), and changing to use UserContext type: https://supertokens.com/docs/thirdpartyemailpassword/common-customizations/sessions/claims/claim-validators#on-the-backendAbout access denied factor ID on the frontend and backend setup sections..await Claim.refresh()
on the frontend, andawait session.fetchAndSet(claim)
on the backend./docs/thirdpartyemailpassword/advanced-customizations/frontend-hooks/handle-event
, we need to also check for isFirstFactor to make sure that events only get fired once./docs/thirdpartyemailpassword/pre-built-ui/auth-redirection
, we need to mention that getRedirectURL with success context is only called for the first factor. and not all factors.newSessionCreated
In 2fa when calling createCode, we have to pass in the factor id, but not in first factor.. Not needed anymore cause no first factors as an input to createCodeChanges phone password recipe to be phone otp + password as opposed to just phone password (this should be done via MFA)Decided not to do this cause the older method works and is free.