ADG Integration #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
143666a to
7a85e8a
Compare
1c0b352 to
12d73a3
Compare
ghost
commented
Mar 16, 2020
12d73a3 to
9efa677
Compare
ghost
commented
Mar 16, 2020
1f3e3d3 to
0016083
Compare
ghost
commented
Mar 25, 2020
0016083 to
1cf8c94
Compare
ghost
commented
Apr 2, 2020
1cf8c94 to
805cee4
Compare
ghost
commented
Apr 7, 2020
| Ttl uint64 `json:"ttl"` | ||
| Vastxml string `json:"vastxml,omitempty"` | ||
| LandingUrl string `json:"landing_url"` | ||
| Scheduleid string `json:"scheduleid"` |
There was a problem hiding this comment.
必須ではないです！
https://www.iab.com/wp-content/uploads/2016/03/OpenRTB-API-Specification-Version-2-5-FINAL.pdf
4.2.3 Object: Bid
dealid Reference to the `deal.id` from the bid request if this bid
pertains to a private marketplace direct deal.
とあるのですが、ADGのbidResponseにこれに該当する値って存在しますか？
ghost
commented
Apr 7, 2020
adapters/adgeneration/adgenerationtest/exemplary/single-banner.json
Outdated
Show resolved
Hide resolved
6a19150 to
52cfa83
Compare
52cfa83 to
b18d506
Compare
ghost
pushed a commit
that referenced
this pull request
Sep 28, 2020
* Pubstack Analytics V1 (prebid#11) * V1 Pubstack (#7) * feat: Add Pubstack Logger (#6) * first version of pubstack analytics * bypass viperconfig * commit #1 * gofmt * update configuration and make the tests pass * add readme on how to configure the adapter and update the network calls * update logging and fix intake url definition * feat: Pubstack Analytics Connector * fixing go mod * fix: bad behaviour on appending path to auction url * add buffering * support bootstyrap like configuration * implement route for all the objects * supports termination signal handling for goroutines * move readme to the correct location * wording * enable configuration reload + add tests * fix logs messages * fix tests * fix log line * conclude merge * merge * update go mod Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * fix duplicated channel keys Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * first pass - PR reviews * rename channel* -> eventChannel * dead code * Review (#10) * use json.Decoder * update documentation * use nil instead []byte("") * clean code * do not use http.DefaultClient * fix race condition (need validation) * separate the sender and buffer logics * refactor the default configuration * remove error counter * Review GP + AR * updating default config * add more logs * remove alias fields in json * fix json serializer * close event channels Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com> * fix race condition * first pass (pr reviews) * refactor: store enabled modules into a dedicated struct * stop goroutine * test: improve coverage * PR Review * Revert "refactor: store enabled modules into a dedicated struct" This reverts commit f57d9d6. # Conflicts: # analytics/config/config_test.go Co-authored-by: Amaury Ravanel <amaury.ravanel@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prebid.js PR
prebid/Prebid.js#2034
Prebid server 仕様
http://prebid.org/dev-docs/get-started-with-prebid-server.html
または、ローカルPCのbidder実装.md 参照