Skip to content
This repository has been archived by the owner on Mar 5, 2021. It is now read-only.

Add Typescript editor #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Typescript editor #6

wants to merge 3 commits into from

Conversation

briangtn
Copy link
Contributor

@briangtn briangtn commented Jan 9, 2016

No description provided.

@elisee
Copy link
Contributor

elisee commented Jan 9, 2016

OK we're getting there 👍

There are a few changes to make as @bilou84 said: #2 (comment).

You don't need to close the pull request or delete the branch to do it! Just amend your commit and force push. Let me know if you need guidance :)

@briangtn
Copy link
Contributor Author

Okey it's good ?

@bilou84
Copy link
Contributor

bilou84 commented Jan 10, 2016

You didn't have to do a new commit. You could amend the first one and force push it.
Now that you have two, you should be able to squash them into one.

@briangtn
Copy link
Contributor Author

@bilou84 Okey in git ext. I click on "Ecraser le commit" ?

@bilou84
Copy link
Contributor

bilou84 commented Jan 10, 2016

Yes this one

@elisee
Copy link
Contributor

elisee commented Jan 28, 2016

This needs some review and additional work. We'll get back to it once the dust has settled on the core itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants