Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SuperEditor][SuperReader] - Add support for inline images and gifs #2442

Closed
matthew-carroll opened this issue Dec 4, 2024 · 0 comments · Fixed by #2450
Closed

[SuperEditor][SuperReader] - Add support for inline images and gifs #2442

matthew-carroll opened this issue Dec 4, 2024 · 0 comments · Fixed by #2450
Assignees
@matthew-carroll
Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup f:superlist Funded by Superlist time:10 Spend 10 hours or less

Comments

@matthew-carroll
Copy link
Contributor

First, we need placeholders in AttributedText: #2440

Second, we need inline widget rendering in SuperText: #2441

Then, for this ticket, utilize inline widgets in SuperEditor and SuperReader. This includes at least the following concerns:

  • Caret and selection box rendering
  • User tap and drag resolution to document positions
  • Arrow key caret movement around images
  • Image insertion (including paste)
  • Image deletion (including implicit deletion with expanded selections)
@matthew-carroll matthew-carroll added area_supereditor Pertains to SuperEditor bounty_junior f:superlist Funded by Superlist time:10 Spend 10 hours or less area_super_reader Related to SuperReader f:clickup labels Dec 4, 2024
@matthew-carroll matthew-carroll self-assigned this Dec 4, 2024
@matthew-carroll matthew-carroll mentioned this issue Dec 4, 2024
Open
matthew-carroll added a commit that referenced this issue Dec 10, 2024
@matthew-carroll
[SuperEditor][SuperReader] - Added support for inline widgets (Resolves
a79e5a3 
#2442)
@matthew-carroll matthew-carroll mentioned this issue Dec 10, 2024
Merged
github-actions bot pushed a commit that referenced this issue Dec 20, 2024
@matthew-carroll @web-flow
[SuperEditor][SuperReader] - Added support for inline widgets (Resolves
5a83a0f 
#2442) (#2450)
matthew-carroll pushed a commit that referenced this issue Dec 20, 2024
@github-actions
Cherry Pick: [SuperEditor][SuperReader] - Added support for inline wi…
d13f704 
…dgets (Resolves #2442) (#2468)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthew-carroll matthew-carroll

Labels
area_super_reader Related to SuperReader area_supereditor Pertains to SuperEditor bounty_junior f:clickup f:superlist Funded by Superlist time:10 Spend 10 hours or less
Projects
None yet
Milestone
No milestone
1 participant
@matthew-carroll