Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Add optional dependencies on @types/passport, @types/passport-oauth2 #32

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix(types): Add optional dependencies on @types/passport, @types/passport-oauth2 #32

merged 4 commits into from
Jan 5, 2023

Conversation

jnv
Copy link
Collaborator

@jnv jnv commented Jan 2, 2023 •
edited
Loading

Fixes #25

Needs:

  • Changelog
  • Docs
  • Example

@jnv jnv changed the base branch from main to chore/maint January 2, 2023 15:19
This was referenced Jan 2, 2023
Closed
Closed
Base automatically changed from chore/maint to main January 3, 2023 11:01
@jnv jnv marked this pull request as ready for review January 4, 2023 09:58
@jnv
Copy link
Collaborator Author

jnv commented Jan 4, 2023

I've added a changelog entry, but I'd like to keep examples and docs update as separate PRs. I think this can be released as a patch version.

@jnv jnv requested a review from janhalama January 4, 2023 09:59
janhalama
janhalama approved these changes Jan 5, 2023
View reviewed changes
Copy link
Collaborator

@janhalama janhalama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for the fix. I tested it on blank typescript project and it works just fine.

@jnv jnv merged commit dd0ebc6 into main Jan 5, 2023
@jnv jnv deleted the types-deps branch January 5, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janhalama janhalama janhalama approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue setting up Strategy [in TypeScript]
2 participants
@jnv @janhalama