Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use melos for example #480

Merged
merged 2 commits into from
May 26, 2023
Merged

ci: use melos for example #480

merged 2 commits into from
May 26, 2023

Conversation

Vinzent03
Copy link
Collaborator

The workflow failes for supabaes_flutter, if the version of supabase changes. https://github.com/supabase/supabase-flutter/actions/runs/5040611117/jobs/9039549791

Instead I'm now using a normal version and include it in melos

@Vinzent03 Vinzent03 requested a review from dshukertjr May 24, 2023 18:26
@dshukertjr
Copy link
Member

Nice one! Yeah, this was a bit annoying. It seems like a bug on pub. dart-lang/pub#2447

melos.yaml Outdated
@@ -3,6 +3,7 @@ repository: https://github.com/supabase/supabase-flutter

packages:
- packages/*
- packages/supabase_flutter/example
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it locally, and it seemed like just by specifying a version in pubspec.yaml instead of a path was enough, hence we might be able to get rid of this line. Would you be able to confirm and if that's the case, remove this line?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, it works without melos as well. I inspired from flutterfire melos.yaml. The way it currently is, I think melos would update the version of supabase_flutter in the example pubspec when we update supabase_flutter. Though I don't know if it occurs in the changelog or similar as well, so I'm fine with deleting it as well and time to time update the version manually.

@Vinzent03
Copy link
Collaborator Author

By the way, did you manually publish the latest versions? I can't find the actions that should have run. At least they should have been triggered.

@dshukertjr
Copy link
Member

@Vinzent03 Yup, I manually published the versions. I was going to look into it when I have time, but melos makes it easy to publish all the packages anyway, so it was low priority to me. If you want to look into it, that would be great, but again, I don't it's really not a high priority.

@dshukertjr dshukertjr merged commit 8b154c2 into main May 26, 2023
@dshukertjr dshukertjr deleted the ci/example branch May 26, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants