fix: Reduce janitor scope to only local tenants #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
hauleth
approved these changes
Feb 20, 2025
lib/realtime/tenants/janitor.ex
Outdated
| @@ -65,7 +65,7 @@ defmodule Realtime.Tenants.Janitor do | |||
| Logger.info("Janitor started") | |||
| %{chunks: chunks, tasks: tasks} = state | |||
| all_tenants = :ets.select(@table_name, [{{:"$1"}, [], [:"$1"]}]) | |||
| connected_tenants = :ets.select(@syn_table, [{{:"$1", :_, :_, :_, :_, :_}, [], [:"$1"]}]) | |||
| connected_tenants = :ets.select(@syn_table, [{{:"$1", :_, :_, :_, :_, Node.self()}, [], [:"$1"]}]) | |||
There was a problem hiding this comment.
Sweet match specs. Technically it probably should be {:const, Node.self()} but I think that it will not cause any issues there.
There was a problem hiding this comment.
will do the change so it's more correct
There was a problem hiding this comment.
yeah this is better and more correct :D
|
🎉 This PR is included in version 2.34.26 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Reduce janitor scope to only local tenants
