Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Broadcast Handler refactor #1293

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

  • Skips message counting in case of bad auth
  • Simplifies approach and code in both Broadcast Handler and Realtime Channel
  • Adds more tests to Broadcast Handler use cases apart from rt_channel integration tests
  • Adds RateCounter stop to reduce test flakiness

Copy link

vercel bot commented Feb 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Feb 10, 2025 4:48pm

* Skips message counting in case of bad auth
* Simplifies approach and code in both Broadcast Handler and Realtime Channel
* Adds more tests to Broadcast Handler use cases apart from rt_channel integration tests
* Adds RateCounter stop to reduce test flakiness
@filipecabaco filipecabaco force-pushed the fix/broadcast-handler-refactor branch from f28ed8a to 60725ad Compare February 10, 2025 16:48
@filipecabaco filipecabaco merged commit c7ea914 into main Feb 10, 2025
4 of 5 checks passed
@filipecabaco filipecabaco deleted the fix/broadcast-handler-refactor branch February 10, 2025 19:27
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.34.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants