Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: missing error propagation in internal/models.ConfirmPhone #1939

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: missing error propagation in internal/models.ConfirmPhone #1939

wants to merge 1 commit into from

Conversation

cstockton
Copy link
Contributor

Propagate errors that occur when calling tx.UpdateOnly in internal/models/user.go:ConfirmPhone.

@cstockton cstockton requested a review from a team as a code owner February 10, 2025 19:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13248595273

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 67.495%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/models/user.go 0 1 0.0%
Totals Coverage Status
Change from base Build 13205664056: 0.0%
Covered Lines: 10208
Relevant Lines: 15124
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hf hf hf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cstockton @coveralls @hf